From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15205 invoked by alias); 6 Feb 2006 23:02:20 -0000 Received: (qmail 15196 invoked by uid 22791); 6 Feb 2006 23:02:20 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Feb 2006 23:02:17 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k16N1hPh005603; Tue, 7 Feb 2006 00:01:43 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k16N1hvM021227; Tue, 7 Feb 2006 00:01:43 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k16N1hdu008774; Tue, 7 Feb 2006 00:01:43 +0100 (CET) Date: Mon, 06 Feb 2006 23:02:00 -0000 Message-Id: <200602062301.k16N1hdu008774@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20060206210238.GB28917@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 6 Feb 2006 16:02:38 -0500) Subject: Re: RFA: Various Windows (mingw32) additions, mostly relating to select or serial ports References: <20060203220529.GA3578@nevyn.them.org> <20060206210238.GB28917@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00140.txt.bz2 > Date: Mon, 6 Feb 2006 16:02:38 -0500 > From: Daniel Jacobowitz > > On Fri, Feb 03, 2006 at 05:05:29PM -0500, Daniel Jacobowitz wrote: > > Fixes, all for a mingw32-hosted GDB: > > Here is a revised version, in which the Windows select magic does not > live in event-loop.c, and including the NEWS entry. I haven't changed > the pipe polling code; thanks to Ian for his suggestions, but I'm > not sufficiently sure they're workable. > > Are there any bits of this patch that strike you as too ugly or in the > wrong place? Hmm, can't mingw_select() just be called select()? That'd remove much of the ugliness. Mark