From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15294 invoked by alias); 6 Feb 2006 17:54:05 -0000 Received: (qmail 15284 invoked by uid 22791); 6 Feb 2006 17:54:05 -0000 X-Spam-Check-By: sourceware.org Received: from cgf.cx (HELO cgf.cx) (24.61.23.223) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Feb 2006 17:54:03 +0000 Received: by cgf.cx (Postfix, from userid 201) id C74E713C0F8; Mon, 6 Feb 2006 12:54:01 -0500 (EST) Date: Mon, 06 Feb 2006 17:54:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: RFA: Support Windows extended error numbers in safe_strerror Message-ID: <20060206175401.GB6428@trixie.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <20060203215455.GA3501@nevyn.them.org> <20060206173550.GB22947@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060206173550.GB22947@nevyn.them.org> User-Agent: Mutt/1.5.11 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00128.txt.bz2 On Mon, Feb 06, 2006 at 12:35:50PM -0500, Daniel Jacobowitz wrote: >On Fri, Feb 03, 2006 at 04:54:55PM -0500, Daniel Jacobowitz wrote: >> This is an improved version of a patch Mark Mitchell submitted last >> year. If you give strerror() anything above 42 (sys_nerr) on Windows, >> it gives you back "Unknown error" - particularly unfortunate since >> WSAECONNREFUSED is way above there, so connecting to a closed socket >> will give you a generic error message. This patch lets us try an >> OS-specific interface to fetch an error string. >> >> [Actually you need my next patch too to get the connection refused message; >> right now you'll get a timeout.] >> >> Any comments on this patch? > >There were plenty :-) Is this better? > >We had finally eliminated the XM files in favor of autoconf checks. >This patch re-adds an xm-*.h header file, but I think it's still >the best of our options. We can restrict our use of these headers >to things where autoconf is a bad fit - like right here. > >Rather than creating a .mh file and setting XM_FILE there, I added >this and an equivalent to TDEPFILES to configure.host. This is in >line with discussion I vaguely remember from last year that the >makefile fragments were not a preferable solution for this sort >of thing. I do agree that it looks more elegant this way. I don't remember this discussion but I think this looks fine. I don't have any problem supporting this so there is no need (yet) to change the maintainer rules. So, if I have the authority to say go ahead and check this in then "Go ahead and check this in". cgf