From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31645 invoked by alias); 4 Feb 2006 14:53:35 -0000 Received: (qmail 31634 invoked by uid 22791); 4 Feb 2006 14:53:34 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 04 Feb 2006 14:53:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F5On6-0004W0-6d for gdb-patches@sourceware.org; Sat, 04 Feb 2006 09:53:32 -0500 Date: Sat, 04 Feb 2006 14:53:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: RFA: Support Windows extended error numbers in safe_strerror Message-ID: <20060204145332.GB17011@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060203215455.GA3501@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00074.txt.bz2 On Sat, Feb 04, 2006 at 01:58:45PM +0200, Eli Zaretskii wrote: > How about if you put this in some function on win32-nat.c, and then > leave only the conditional call to that function in utils.c? Actualy, > perhaps we don't need any ifdef at all, since I think there's no way > the argument can be greater than sys_nerr on other platforms, right? Well, it can't be in win32-nat.c - it's for Windows hosting rather than Windows native. But I could move the code to a new Windows-specific file, like ser-windows.o introduced in my other patch, and call it there. I've no objection to that. -- Daniel Jacobowitz CodeSourcery