From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8923 invoked by alias); 2 Feb 2006 01:43:14 -0000 Received: (qmail 8908 invoked by uid 22791); 2 Feb 2006 01:43:13 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 02 Feb 2006 01:43:12 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F4TV6-00057I-4Z; Wed, 01 Feb 2006 20:43:08 -0500 Date: Thu, 02 Feb 2006 01:43:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: Eli Zaretskii , gdb-patches@sources.redhat.com, bje@au1.ibm.com, anton@au1.ibm.com, pgilliam@us.ibm.com Subject: Re: [RFC] GDB patches for hw watchpoints - revised Message-ID: <20060202014308.GA19507@nevyn.them.org> Mail-Followup-To: Wu Zhou , Eli Zaretskii , gdb-patches@sources.redhat.com, bje@au1.ibm.com, anton@au1.ibm.com, pgilliam@us.ibm.com References: <20060122205641.GF27224@nevyn.them.org> <20060124034304.GA4719@nevyn.them.org> <20060124212046.GC26974@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00017.txt.bz2 On Wed, Jan 25, 2006 at 04:34:14PM +0800, Wu Zhou wrote: > I am also thinking of replace the macro > TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT (SIZE) with > TARGET_REGION_OK_FOR_HW_WATCHPOINT(ADDR, SIZE). Thus the code will seem > to be more clean: we will only have one macro to see if the target region > is ok for watchpoint monitoring. Following this way, function > default_region_ok_for_hw_watchpoint will also return back to its original > implementation. What is your thought on this? I'm not sure what you mean. After these patches, the only reference to TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT is in gdbint.texinfo (which I'd appreciate if you fixed, in a separate patch - thanks in advance). What are the two ways now? On Wed, Jan 25, 2006 at 11:18:49AM +0800, Wu Zhou wrote: > OK to commit? > > 2006-01-22 Ben Elliston > Wu Zhou > > * ppc-linux-nat.c (PTRACE_GET_DEBUGREG, PTRACE_SET_DEBUGREG, > PTRACE_GETSIGINFO): Define. > (last_stopped_data_address): New. > (ppc_linux_check_watch_resources): New function. > (ppc_linux_region_ok_for_hw_watchpoint): New function. > (ppc_linux_insert_watchpoint): New function. > (ppc_linux_remove_watchpoint): New function. > (ppc_linux_stopped_data_address): New function. > (ppc_linux_stopped_by_watchpoint): New function. > (_initialize_ppc_linux_nat): Set the above hardware watchpoint > related target vectors. > * rs6000-tdep.c (rs6000_gdbarch_init): Set PPC architectures > to have nonsteppable watchpoint. > * target.c (default_region_ok_for_hw_watchpoint, > debug_to_region_ok_for_hw_watchpoint): New prototypes. > (update_current_target): Inherit to_region_ok_for_hw_watchpoint > and set default to_region_ok_for_hw_watchpoint. > (default_region_ok_for_hw_watchpoint): New function. > (debug_to_region_ok_for_hw_watchpoint): New function. > (setup_target_debug): Set to_region_ok_for_hw_watchpoint of > debug_target. > * target.h (struct target_ops): Add a new target vector > to_region_ok_for_hw_watchpoint. > (TARGET_REGION_OK_FOR_HW_WATCHPOINT): Define this if it is not > defined anyplace else. On Wed, Jan 25, 2006 at 04:34:14PM +0800, Wu Zhou wrote: > 2006-01-25 Wu Zhou > > * breakpoint.c (TARGET_REGION_OK_FOR_HW_WATCHPOINT): Delete. > * config/i386/nm-i386sol2.h (TARGET_REGION_OK_FOR_HW_WATCHPOINT): New. > (TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Delete. > * config/mips/nm-irix5.h (TARGET_REGION_OK_FOR_HW_WATCHPOINT): New. > (TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Delete. > * config/sparc/nm-sol2.h (TARGET_REGION_OK_FOR_HW_WATCHPOINT): New. > (TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Delete. > * inf-ttrace.c (inf_ttrace_region_ok_for_hw_watchpoint): New. > (inf_ttrace_region_size_ok_for_hw_watchpoint): Delete. > (inf_ttrace_target): Delete to_region_size_ok_for_hw_watchpoint and > add to_region_ok_for_hw_watchpoint. > * s390-nat.c (s390_region_size_ok_for_hw_watchpoint): Delete. > (s390_region_ok_for_hw_watchpoint): New. > (_initialize_s390_nat): Delete to_region_size_ok_for_hw_watchpoint > and add to_region_ok_for_hw_watchpoint. > * target.c (default_region_size_ok_for_hw_watchpoint, > debug_to_region_size_ok_for_hw_watchpoint): Delete prototype. > (update_current_target): Delete to_region_size_ok_for_hw_watchpoint > inheritance and default_region_size_ok_for_hw_watchpoint. > (default_region_ok_for_hw_watchpoint): If len is less than or equal > the length of void pointer, return ok. > (default_region_size_ok_for_hw_watchpoint): Delete. > (debug_to_region_size_ok_for_hw_watchpoint): Delete. > (setup_target_debug): Delete to_region_size_ok_for_hw_watchpoint. > * target.h (struct target_ops): Delete > to_region_size_ok_for_hw_watchpoint. > (TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Delete. These patches are both OK. You might want to combine them - it's a much smaller diff :-) But it doesn't matter since you've already got them separated out. -- Daniel Jacobowitz CodeSourcery