From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23951 invoked by alias); 1 Feb 2006 22:32:41 -0000 Received: (qmail 23943 invoked by uid 22791); 1 Feb 2006 22:32:41 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 01 Feb 2006 22:32:36 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F4QWe-0004C9-OW; Wed, 01 Feb 2006 17:32:32 -0500 Date: Wed, 01 Feb 2006 22:32:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add fullname field for MI -break-info command Message-ID: <20060201223232.GB14187@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200601241932.16022.ghost@cs.msu.su> <20060124165136.GF28357@brasko.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00011.txt.bz2 On Sat, Jan 28, 2006 at 04:09:42PM +0300, Vladimir Prus wrote: > Revised patch attached. I did verify that it causes no regressions for MI > tests. > > > Note, however, that I could not verify that it does not cause any > regressions globally, because something seems wrong with my configuration > or the test system. Sporadically, I get errors like this: What system are you testing on? Presumably a bug in the host or in the port of expect to the host. I've verified no regressions on x86_64-pc-linux-gnu. The patch looks OK. There's a couple of formatting errors, and it needs ChangeLog entries, and then it can be applied. Oh, and Nick was right: you don't need the loc_type check any more. Everything in that case statement will be a breakpoint and have a valid address. > + struct symtab_and_line sal = find_pc_line (b->loc->address, 0); > + char* fullname = symtab_to_fullname (sal.symtab); char *fullname, please, for consistency. > + if (fullname) > + { > + ui_out_field_string (uiout, "fullname", fullname); > + } Don't need the extra braces here. > @@ -75,25 +78,27 @@ > # -break-insert -t srcfile:$line_callee4_head > # -break-list > > + > + > mi_gdb_test "222-break-insert -t main" \ > - "222\\^done,bkpt=\{number=\"1\",type=\"breakpoint\",disp=\"del\",enabled=\"y\",addr=\"$hex\",func=\"main\",file=\".*basics.c\",line=\"$line_main_body\",times=\"0\"\}" \ > + "222\\^done,bkpt=\{number=\"1\",type=\"breakpoint\",disp=\"del\",enabled=\"y\",addr=\"$hex\",func=\"main\",file=\".*basics.c\",${fullname},line=\"$line_main_body\",times=\"0\"\}" \ > "break-insert -t operation" And don't need the extra blank lines. -- Daniel Jacobowitz CodeSourcery