From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19752 invoked by alias); 31 Jan 2006 03:38:41 -0000 Received: (qmail 19732 invoked by uid 22791); 31 Jan 2006 03:38:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 31 Jan 2006 03:38:39 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F3mLl-0006sC-CK; Mon, 30 Jan 2006 22:38:37 -0500 Date: Tue, 31 Jan 2006 03:38:00 -0000 From: Daniel Jacobowitz To: Eirik Fuller Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use mmap for symbol tables Message-ID: <20060131033837.GA26401@nevyn.them.org> Mail-Followup-To: Eirik Fuller , gdb-patches@sourceware.org References: <20060129233630.3EFA6690067@ns.hackrat.org> <20060131022330.GA24934@nevyn.them.org> <43DED9FA.1070305@hackrat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43DED9FA.1070305@hackrat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00481.txt.bz2 On Mon, Jan 30, 2006 at 07:31:06PM -0800, Eirik Fuller wrote: > > One important note: you bypassed symfile_relocate_debug_section. > > I'll look at it. It hasn't yet been an issue in anything I've used my > gdb mmap patches with, but offhand I'd expect it should be easy to find > something that does trip over that. I can watch attempts to write back > to the readonly mmap region from gdb, and maybe cobble together some > malloc glue which provides the illusion of copy on write. Or maybe just > convince myself that MAP_PRIVATE is the right answer (but it might be > better to keep PROT_READ, just to really keep track of what gdb needs to > modify and what it doesn't need to modify). No, probably you should just bypass the mmap if the code in that function triggers. -- Daniel Jacobowitz CodeSourcery