From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21633 invoked by alias); 26 Jan 2006 11:44:22 -0000 Received: (qmail 21618 invoked by uid 22791); 26 Jan 2006 11:44:21 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jan 2006 11:44:20 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1F25Y1-0005ZB-8N for gdb-patches@sources.redhat.com; Thu, 26 Jan 2006 14:44:17 +0300 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1F25Xv-0005Xq-IX; Thu, 26 Jan 2006 14:44:11 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: [PATCH] Add fullname field for MI -break-info command Date: Thu, 26 Jan 2006 11:44:00 -0000 User-Agent: KMail/1.7.2 Cc: gdb-patches@sources.redhat.com References: <17368.45539.671403.826516@kahikatea.snap.net.nz> In-Reply-To: <17368.45539.671403.826516@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601261444.10132.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00425.txt.bz2 On Thursday 26 January 2006 14:26, Nick Roberts wrote: > + if (ui_out_is_mi_like_p (uiout)) > + { > + if (b->loc->loc_type == bp_loc_software_breakpoint || > + b->loc->loc_type == bp_loc_hardware_watchpoint) > ^^^^^^^^^^ > Should this be bp_loc_hardware_breakpoint? You're right, it's a typo. > + } > + } > + > > Also, I would move it up breakpoint.c (without the call to annotate_field) > to here: > > if (b->source_file) > { > sym = find_pc_sect_function (b->loc->address, b->loc->section); > if (sym) > { > ui_out_text (uiout, "in "); > ui_out_field_string (uiout, "func", > SYMBOL_PRINT_NAME (sym)); > ui_out_wrap_hint (uiout, wrap_indent); > ui_out_text (uiout, " at "); > } > ui_out_field_string (uiout, "file", b->source_file); > ui_out_text (uiout, ":"); > > ---> > > ui_out_field_int (uiout, "line", b->line_number); > } > > to be consistent with the output of print_frame, where the order is > file, fullname, line. Makes sense. > Putting it here might also mean that the test for b->loc->loc_type isn't > needed, but I don't really know. Can anybody comment on this? Thanks, Volodya