Re: [PATCH] Add fullname field for MI -break-info command

Vladimir Prus
2006-01-25T13:31:29Z

On Wednesday 25 January 2006 00:13, Daniel Jacobowitz wrote:

> > + {
> > + struct symtab_and_line sal = find_pc_line (b->loc->address,
> > 0); + symtab_to_fullname (sal.symtab);
> > +
> > + if (sal.symtab->fullname)
> > + {
> > + annotate_field(10);
>
> annotate_field (10);

Is that a formatting change, or moving the "annotate_field" call out of "if"?

> But I don't think you need this at all; there's no point emitting
> annotations when we're guarded by ui_out_is_mi_like_p.

For a future: can you explain what "annotate_field" does? The annotate.h file
has no comments at all, and gdbint has "annotate_field" only inside code
examples. And generally, what are "annotations"?

> Also, you can use the return value from symtab_to_fullname.

Point taken.

- Volodya