From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3525 invoked by alias); 25 Jan 2006 13:31:29 -0000 Received: (qmail 3493 invoked by uid 22791); 25 Jan 2006 13:31:26 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jan 2006 13:31:26 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1F1kk4-0000SV-A6 for gdb-patches@sources.redhat.com; Wed, 25 Jan 2006 16:31:21 +0300 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1F1kk4-0000SR-8R for gdb-patches@sources.redhat.com; Wed, 25 Jan 2006 16:31:20 +0300 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add fullname field for MI -break-info command Date: Wed, 25 Jan 2006 13:31:00 -0000 User-Agent: KMail/1.7.2 References: <200601241932.16022.ghost@cs.msu.su> <20060124211334.GB26974@nevyn.them.org> In-Reply-To: <20060124211334.GB26974@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200601251631.19779.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00406.txt.bz2 On Wednesday 25 January 2006 00:13, Daniel Jacobowitz wrote: > > + { > > + struct symtab_and_line sal = find_pc_line (b->loc->address, > > 0); + symtab_to_fullname (sal.symtab); > > + > > + if (sal.symtab->fullname) > > + { > > + annotate_field(10); > > annotate_field (10); Is that a formatting change, or moving the "annotate_field" call out of "if"? > But I don't think you need this at all; there's no point emitting > annotations when we're guarded by ui_out_is_mi_like_p. For a future: can you explain what "annotate_field" does? The annotate.h file has no comments at all, and gdbint has "annotate_field" only inside code examples. And generally, what are "annotations"? > Also, you can use the return value from symtab_to_fullname. Point taken. - Volodya