From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14312 invoked by alias); 25 Jan 2006 13:51:28 -0000 Received: (qmail 14288 invoked by uid 22791); 25 Jan 2006 13:51:28 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 25 Jan 2006 13:51:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F1l3S-0002pI-Uu for gdb-patches@sourceware.org; Wed, 25 Jan 2006 08:51:23 -0500 Date: Wed, 25 Jan 2006 13:51:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [PATCH] Add fullname field for MI -break-info command Message-ID: <20060125135122.GA10783@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200601241932.16022.ghost@cs.msu.su> <20060124211334.GB26974@nevyn.them.org> <200601251631.19779.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601251631.19779.ghost@cs.msu.su> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00409.txt.bz2 On Wed, Jan 25, 2006 at 04:31:19PM +0300, Vladimir Prus wrote: > On Wednesday 25 January 2006 00:13, Daniel Jacobowitz wrote: > > > > + { > > > + struct symtab_and_line sal = find_pc_line (b->loc->address, > > > 0); + symtab_to_fullname (sal.symtab); > > > + > > > + if (sal.symtab->fullname) > > > + { > > > + annotate_field(10); > > > > annotate_field (10); > > Is that a formatting change, or moving the "annotate_field" call out of "if"? Sorry, I just meant the space before the parentheses. > > But I don't think you need this at all; there's no point emitting > > annotations when we're guarded by ui_out_is_mi_like_p. > > For a future: can you explain what "annotate_field" does? The annotate.h file > has no comments at all, and gdbint has "annotate_field" only inside code > examples. And generally, what are "annotations"? As Bob said, an old interface. See "set annotate". -- Daniel Jacobowitz CodeSourcery