From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10568 invoked by alias); 25 Jan 2006 13:46:20 -0000 Received: (qmail 10516 invoked by uid 22791); 25 Jan 2006 13:46:16 -0000 X-Spam-Check-By: sourceware.org Received: from eastrmmtao03.cox.net (HELO eastrmmtao03.cox.net) (68.230.240.36) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jan 2006 13:46:14 +0000 Received: from localhost.localdomain ([68.9.66.48]) by eastrmmtao03.cox.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20060125134616.ZFGE29285.eastrmmtao03.cox.net@localhost.localdomain>; Wed, 25 Jan 2006 08:46:16 -0500 Received: from bob by localhost.localdomain with local (Exim 4.52) id 1F1kyz-0005Sa-KZ; Wed, 25 Jan 2006 08:46:45 -0500 Date: Wed, 25 Jan 2006 13:46:00 -0000 From: Bob Rossi To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add fullname field for MI -break-info command Message-ID: <20060125134645.GC20856@brasko.net> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200601241932.16022.ghost@cs.msu.su> <20060124211334.GB26974@nevyn.them.org> <200601251631.19779.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601251631.19779.ghost@cs.msu.su> User-Agent: Mutt/1.5.9i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00408.txt.bz2 On Wed, Jan 25, 2006 at 04:31:19PM +0300, Vladimir Prus wrote: > On Wednesday 25 January 2006 00:13, Daniel Jacobowitz wrote: > > > > + { > > > + struct symtab_and_line sal = find_pc_line (b->loc->address, > > > 0); + symtab_to_fullname (sal.symtab); > > > + > > > + if (sal.symtab->fullname) > > > + { > > > + annotate_field(10); > > > > annotate_field (10); > > Is that a formatting change, or moving the "annotate_field" call out of "if"? > > > But I don't think you need this at all; there's no point emitting > > annotations when we're guarded by ui_out_is_mi_like_p. > > For a future: can you explain what "annotate_field" does? The annotate.h file > has no comments at all, and gdbint has "annotate_field" only inside code > examples. And generally, what are "annotations"? Annotations were the old interface used between GDB and front ends. It was all that was available before MI. For your own sanity, never ever try to deal with them. Thanks, Bob Rossi