From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1105 invoked by alias); 25 Jan 2006 12:10:01 -0000 Received: (qmail 1044 invoked by uid 22791); 25 Jan 2006 12:10:00 -0000 X-Spam-Check-By: sourceware.org Received: from eastrmmtao06.cox.net (HELO eastrmmtao06.cox.net) (68.230.240.33) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jan 2006 12:09:59 +0000 Received: from localhost.localdomain ([68.9.66.48]) by eastrmmtao06.cox.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20060125120959.SJPG9108.eastrmmtao06.cox.net@localhost.localdomain>; Wed, 25 Jan 2006 07:09:59 -0500 Received: from bob by localhost.localdomain with local (Exim 4.52) id 1F1jTq-0004yd-Vq; Wed, 25 Jan 2006 07:10:30 -0500 Date: Wed, 25 Jan 2006 12:10:00 -0000 From: Bob Rossi To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add fullname field for MI -break-info command Message-ID: <20060125121030.GJ28357@brasko.net> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200601241932.16022.ghost@cs.msu.su> <20060124165136.GF28357@brasko.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00403.txt.bz2 On Wed, Jan 25, 2006 at 02:07:28PM +0300, Vladimir Prus wrote: > Bob Rossi wrote: > > > On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote: > >> > >> Hello! > >> > >> The attached patch adds the "fullname" field to the output of MI > >> -break-info command. > > > > The patch seems good to me at first glance. However, you should also > > update the testsuite, and send in the patch for that as well. > > I'm looking into this right now, and have a question. Inside the test, I > need to get the absolute path to the source file. If I use: > > "${srcdir}/${subdir}/${srcfile}" > > the result is: > > "../.././gdb/testsuite/gdb.mi/basics.c" No, please user ${fullname_syntax}${srcfile}. That will provide you with a regular expression that matches the fullname, and end in the source file you are interestd in. You can see how this is done in mi2-stack.exp. > while output of gdb has absolute path name. So: how do I convert relative > path to an absolute one inside a test? (I don't know anything about Tcl, so > it's not obvious for me). > > BTW, it would be nice in gdbint explicitly said how one can run a specific > test from testsuite. Yeah, I totally agree. I forget every time. Try 'runtest mi2-stack.exp', to run just that test. > > Also, don't forget about the documentation. > > Well, at the moment the -break-info command is not documented at all, so > there's no place where I can add the extra "fullname" field. Hmm, there is a section in the gdb.texinfo manual that says @c REDUNDANT??? Get information about a single breakpoint. how is this command useful, instead of just using -break-list? Thanks, Bob Rossi