From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3684 invoked by alias); 20 Jan 2006 23:35:24 -0000 Received: (qmail 3676 invoked by uid 22791); 20 Jan 2006 23:35:23 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 20 Jan 2006 23:35:22 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F05mq-0005p7-7K; Fri, 20 Jan 2006 18:35:20 -0500 Date: Fri, 20 Jan 2006 23:35:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: gdb-patches@sources.redhat.com Subject: Re: [SH] PATCH: Define the register groups Message-ID: <20060120233520.GJ21181@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , gdb-patches@sources.redhat.com References: <436105B8.7020605@st.com> <436F6CF7.1070003@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <436F6CF7.1070003@st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00266.txt.bz2 On Mon, Nov 07, 2005 at 03:04:23PM +0000, Andrew STUBBS wrote: > * sh-tdep.c: Include reggroups.h. > (sh_register_reggroup_p): New function. > (sh_gdbarch_init): Add call to set_gdbarch_register_reggroup_p. > * Makefile.in (sh-tdep.o): Add dependency on reggroups.h. Just a couple of questions for you, only one of which involves changing anything: - Are the fv registers for floating point vectors? Since you put them in both info float and info vector. I'm guessing that they are. Makes sense. - Can we reuse default_register_reggroup_p for most of this, and just handle the register numbers that it's likely to get wrong? e.g. we probably do need to handle FPUL here - but calling the default will handle dr0 just fine. - You've put a bunch of registers in system_reggroup (e.g. pc, pr) that other folks don't; but no one besides the TUI uses that anyway, so it doesn't really matter. I wouldn't have included those two. I don't remember what the other ones you listed do, so I've got no idea about them :-) -- Daniel Jacobowitz CodeSourcery