From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4481 invoked by alias); 15 Jan 2006 18:48:08 -0000 Received: (qmail 4471 invoked by uid 22791); 15 Jan 2006 18:48:08 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 15 Jan 2006 18:48:06 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EyCv2-0002am-Sp; Sun, 15 Jan 2006 13:48:01 -0500 Date: Sun, 15 Jan 2006 18:48:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: Jim Blandy , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units Message-ID: <20060115184800.GA9948@nevyn.them.org> Mail-Followup-To: Fred Fish , Jim Blandy , gdb-patches@sourceware.org References: <200601031517.50309.fnf@specifix.com> <200601032147.14083.fnf@specifix.com> <8f2776cb0601031945gb876b84i48c145c291ecbcee@mail.gmail.com> <200601041604.49977.fnf@specifix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601041604.49977.fnf@specifix.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00174.txt.bz2 On Wed, Jan 04, 2006 at 04:04:49PM -0500, Fred Fish wrote: > On Tuesday 03 January 2006 22:45, Jim Blandy wrote: > > > what would break if parse_exp_in_context used the current source > > position as a fallback when get_selected_block returns zero? It > > seems reasonable to me. > > That seems like the most reasonable alternative to me as well. The > following patch solves the same problem as the original patch, in what > is probably a little cleaner way. I don't get any testsuite > regressions when using it. > > -Fred > > 2006-01-04 Fred Fish > > * parse.c (source.h): Include. > (parse_exp_in_context): Use static source context if no > other context found. Given the followups, I think this patch is OK. Jim, do you agree? (Since we currently have new, failing tests...) -- Daniel Jacobowitz CodeSourcery