From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24587 invoked by alias); 15 Jan 2006 18:21:00 -0000 Received: (qmail 24578 invoked by uid 22791); 15 Jan 2006 18:20:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 15 Jan 2006 18:20:57 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EyCUp-0002Gx-A0; Sun, 15 Jan 2006 13:20:55 -0500 Date: Sun, 15 Jan 2006 18:21:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Turn on -Werror by default Message-ID: <20060115182055.GA8189@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200601081759.k08HxOxP007121@elgar.sibelius.xs4all.nl> <20060108222546.GA4147@nevyn.them.org> <200601082253.k08MrLY1000252@elgar.sibelius.xs4all.nl> <20060115170103.GA5830@nevyn.them.org> <200601151755.k0FHtSR9016305@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601151755.k0FHtSR9016305@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00171.txt.bz2 On Sun, Jan 15, 2006 at 06:55:28PM +0100, Mark Kettenis wrote: > From time to time I play with GCC 4, and try to fix a few problems, > but I get the feeling I'm the only one. You may be the only one who prioritizes fixing these warnings, which I still maintain are mostly useless. I think your sample is seriously biased. A few points: - You're the only active GDB developer I can think of offhand that considers the warnings a serious problem. I do consider them a problem - one which should be fixed, before we make policy statements about them. - You're primarily focused on the BSDs, and the BSD system compilers can currently build GDB without warning. - Debian/unstable and Fedora Core, both popular development platforms, can not. - Many people doing development on GDB HEAD are likely to have GCC HEAD lying around, which also can't build GDB with -Werror. This patch is a policy statement that the GDB developers agree with you on the importance of warning-free code, which will inconvenience you not at all, and me a great deal. Can you see where I'm coming from? I maintain that the correct way to turn on -Werror is to first fix the warnings. As the developer who thinks -Werror is an important step forward, the burden is on you to make GDB warning-free on a reasonable set of platforms - I think we both agree on that already. I'm disputing your reasonable set of platforms, however. GCC 4 is unavoidably the future. Ignoring it here won't make it go away, it will just force someone else to clean up after you. > I'm certainly not proposing to do that; even with -Werror enabled, GDB > builds fine on most systems. And when we enable -Werror, we should > seriously consider turning it off again before release. I disagree with "most" in this paragraph. -- Daniel Jacobowitz CodeSourcery