From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16941 invoked by alias); 13 Jan 2006 20:11:44 -0000 Received: (qmail 16933 invoked by uid 22791); 13 Jan 2006 20:11:43 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Jan 2006 20:11:42 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k0DKBbal000130; Fri, 13 Jan 2006 21:11:37 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id k0DKBbOD032083; Fri, 13 Jan 2006 21:11:37 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id k0DKBZ8w006107; Fri, 13 Jan 2006 21:11:35 +0100 (CET) Date: Fri, 13 Jan 2006 20:11:00 -0000 Message-Id: <200601132011.k0DKBZ8w006107@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: andrew.stubbs@st.com CC: gdb-patches@sources.redhat.com In-reply-to: <43C7E466.9080703@st.com> (message from Andrew STUBBS on Fri, 13 Jan 2006 17:33:26 +0000) Subject: Re: [PATCH] Disable thread specific breakpoints when thread dies References: <43723446.7000903@st.com> <20051113184515.GG3599@nevyn.them.org> <437875B0.4000007@st.com> <20051114155659.GA25717@nevyn.them.org> <437A19DE.6040905@st.com> <437B47A1.4040705@st.com> <20051117034811.GB3057@nevyn.them.org> <437CA66B.9060201@st.com> <20060112162659.GA16141@nevyn.them.org> <43C7E466.9080703@st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00146.txt.bz2 > Date: Fri, 13 Jan 2006 17:33:26 +0000 > From: Andrew STUBBS > > Daniel Jacobowitz wrote: > >>> You shouldn't need to use the target method here. Does valid_thread_id > >>> work? > >>> > >>> Also, please remember the space before opening parentheses. > >> The thread still seems to have a valid ID after it has died. You can > >> even do 'b 8 t 4' after the program has exited. It does give an error > >> for threads which never existed though. > > > > Why does that happen? It is presumably a bug. > > > > I have looked into this. The problem is that the threads are only > deleted from the table when 'info threads' is used. The target method > works because that queries the target, not GDB's internal state, and > always gets the right answer (at least in our target interface). > > I am happy, therefore, that the attached patch, with valid_thread_id(), > is correct, and will work once this other problem has been solved (or if > the user types 'info threads'). > > OK to commit? Sorry, but I don't think we should commit a patch that's just papering over some other more serious problem, perhaps perhaps if there's some pressing need to do so. Mark