From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9508 invoked by alias); 11 Jan 2006 04:19:41 -0000 Received: (qmail 9197 invoked by uid 22791); 11 Jan 2006 04:19:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 11 Jan 2006 04:19:37 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EwXSR-0002HK-Gc; Tue, 10 Jan 2006 23:19:35 -0500 Date: Wed, 11 Jan 2006 04:19:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Fix compiler warnings in osabi.c Message-ID: <20060111041935.GA8728@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00110.txt.bz2 On Tue, Jan 10, 2006 at 11:22:23PM +0100, Mark Kettenis wrote: > Another GCC 4 warning; e_ident[] is an array of unsigned chars. I > think the most elegant way to solve this is to use memcmp instead of > strcmp, since we're comparing a string to what may be random garbage, > and not two strings. > > This one isn't quite so obvious, but if nobody objects, I'll commit > this after a week. Yes, looks right to me. -- Daniel Jacobowitz CodeSourcery