From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29464 invoked by alias); 8 Jan 2006 22:57:23 -0000 Received: (qmail 29456 invoked by uid 22791); 8 Jan 2006 22:57:22 -0000 X-Spam-Check-By: sourceware.org Received: from ausmtp03.au.ibm.com (HELO ausmtp03.au.ibm.com) (202.81.18.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jan 2006 22:57:21 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp03.au.ibm.com (8.12.10/8.12.10) with ESMTP id k08N0S9Z048440 for ; Mon, 9 Jan 2006 10:00:29 +1100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0208e0.au.ibm.com (8.12.10/NCO/VERS6.8) with ESMTP id k08N0JCj194098 for ; Mon, 9 Jan 2006 10:00:19 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id k08MvDCD030481 for ; Mon, 9 Jan 2006 09:57:14 +1100 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.190.163.12]) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id k08MvCgM030458; Mon, 9 Jan 2006 09:57:12 +1100 Received: by ozlabs.au.ibm.com (Postfix, from userid 1017) id 9BAC273523; Mon, 9 Jan 2006 09:57:59 +1100 (EST) Date: Sun, 08 Jan 2006 22:57:00 -0000 From: Ben Elliston To: Wu Zhou Cc: gdb-patches@sources.redhat.com, drow@false.org, eliz@gnu.org, mark.kettenis@xs4all.nl, kevinb@redhat.com, uweigand@de.ibm.com, anton@au1.ibm.com Subject: Re: About the patch to add h/w watchpoint to ppc arch Message-ID: <20060108225759.GA20955@ozlabs.au.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00090.txt.bz2 Hi Wu > Are there any other issues? Maybe some documents or testcase? If it > is needed, I can add a testcase for rwatch/awatch or some words > somewhere. I did take a look when I originally wrote the patch and concluded that there was no need for additional test cases. The existing ones in the testsuite seemed to cover things adequately. Indeed, there were some progressions in the test results when I applied my patch. Ben