Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Amit Kale <amitkale@linsyssoft.com>
Cc: GDB patches <gdb-patches@sources.redhat.com>
Subject: Re: Breakpoints in constructors
Date: Tue, 03 Jan 2006 19:40:00 -0000	[thread overview]
Message-ID: <20060103194006.GA12898@nevyn.them.org> (raw)
In-Reply-To: <200601031835.45731.amitkale@linsyssoft.com>

On Tue, Jan 03, 2006 at 06:35:45PM +0530, Amit Kale wrote:
> Hi All,
> 
> I've rebased the breakpoints in constructors patch to current cvs. It's 
> attached for reviews and a submission into mainline gdb after any 
> modifications/improvements as per gdb gurus' suggestions.
> 
> I ran gdb testsuite with this patch and found several failures which were 
> absent in a cvs-built gdb. They are mainly related to "advance" command. I am 
> looking at the failures and trying to fix them. I'll send an update if I can 
> fix any of them.
> 
> I'll very much appreciate any feedback for this.

Hi Amit, and sorry for not getting back to you about this last time you
posted it on gdb@.

The short version is that I believe this is roughly the right approach,
but not quite.  I posted a work-in-progress patch some time ago that
takes a slightly different approach:

Date: Sun, 13 Mar 2005 19:38:24 -0500
From: Daniel Jacobowitz <drow@false.org>
Subject: RFC: First stab at breakpoints in multiple locations

You might want to take a look at that thread, if you haven't already,
to see what I mean.  The basic difference is that instead of "break
Foo::Foo" setting multiple breakpoints, it would set only one
breakpoint, but that breakpoint would be associated with multiple PC
values.

I can't really tell from your patch what cases you do handle or don't;
do breakpoints on constructors by name work?  How about by line number?

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2006-01-03 19:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03 13:06 Amit Kale
2006-01-03 18:53 ` Eli Zaretskii
2006-01-06 13:28   ` Amit Kale
2006-01-03 19:40 ` Daniel Jacobowitz [this message]
2006-01-06 13:26   ` Amit Kale
2006-01-06 13:45     ` Daniel Jacobowitz
2006-01-06 14:19       ` Amit Kale
2006-01-06 14:25         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060103194006.GA12898@nevyn.them.org \
    --to=drow@false.org \
    --cc=amitkale@linsyssoft.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox