From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9057 invoked by alias); 6 Dec 2005 18:23:57 -0000 Received: (qmail 9044 invoked by uid 22791); 6 Dec 2005 18:23:57 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Dec 2005 18:23:56 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.12.10/8.12.10) with ESMTP id jB6IO7BN203710 for ; Tue, 6 Dec 2005 18:24:07 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.12.10/NCO/VERS6.8) with ESMTP id jB6INq4D225530 for ; Tue, 6 Dec 2005 19:23:53 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11/8.13.3) with ESMTP id jB6INqOV031463 for ; Tue, 6 Dec 2005 19:23:52 +0100 Received: from 53v30g16.boeblingen.de.ibm.com (53v30g16.boeblingen.de.ibm.com [9.152.26.156]) by d12av02.megacenter.de.ibm.com (8.12.11/8.12.11) with ESMTP id jB6INqUp031459; Tue, 6 Dec 2005 19:23:52 +0100 Received: from 53v30g16.boeblingen.de.ibm.com (localhost [127.0.0.1]) by 53v30g16.boeblingen.de.ibm.com (8.12.10/8.12.10) with ESMTP id jB6INQXH007021; Tue, 6 Dec 2005 19:23:26 +0100 Received: (from uweigand@localhost) by 53v30g16.boeblingen.de.ibm.com (8.12.10/8.12.10/Submit) id jB6INQFp007018; Tue, 6 Dec 2005 19:23:26 +0100 From: Ulrich Weigand Message-Id: <200512061823.jB6INQFp007018@53v30g16.boeblingen.de.ibm.com> Subject: Re: [RFC] GDB patches for hw watchpoints - revised To: woodzltc@cn.ibm.com (Wu Zhou) Date: Tue, 06 Dec 2005 22:46:00 -0000 Cc: gdb-patches@sources.redhat.com, drow@false.org, eliz@gnu.org, mark.kettenis@xs4all.nl In-Reply-To: from "Wu Zhou" at Dec 06, 2005 02:12:26 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00116.txt.bz2 Wu Zhou wrote: > 4. Mark said that we can't add anything more to nm.h. The revised patch > changed that and add most of them to target vector. But we had to find a > way to set TARGET_REGION_OK_FOR_HW_WATCHPOINT for ppc64 arch. I am now > setting that in nm-ppc64-linux.h. Is that okay? Maybe we need to set > TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT instead? You should be setting the target vector's to_region_size_ok_for_hw_watchpoint function instead. See s390-nat.c where I now implement full watchpoint support without any nm.h macro defined ... Bye, Ulrich -- Dr. Ulrich Weigand Linux on zSeries Development Ulrich.Weigand@de.ibm.com