Re: [PATCH] add 'rs6000_in_function_epilogue_p()' (Revised)

Mark Kettenis
2006-01-17T19:29:16Z

> From: Paul Gilliam <pgilliam@us.ibm.com>
> Date: Mon, 16 Jan 2006 19:15:54 -0800
>
> --Boundary-00=_qFGzDDhs5oqznk3
> Content-Type: text/plain;
> charset="utf-8"
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>
> Mark,
>
> I have made the modifications you asked for.
>
> I would have committed the patch, but I wanted to give you a chance
> to see if my new variable name was ok: fr became curfrm.
>
> It's still a little criptic, but I was trying to avoid making the
> condition of an 'if' statement be on two lines.

Ah, that's a good reason not too make variables and function names
overly long. Personally I'd just named the varible "frame" (that
actually would make the function future safe, since it really should
work for any frame, and take a frame argument instead of a pc, but
that's not your fault.)

> OK to commit?

I'll leave it up to you to change curfrm into frame as suggested
above. So, yes. Thanks!

> I am also concerned about this:
>
> > [ Bleah, I'd really wish people stopped sending MIME mail, especially
> > with that stupid quoted-printable encoding. I hate editing out all
> > those gratuitous equal signs. ]
> >
>
> The mailer I am using is 'kmail'. Here is what I get if I say 'kmail -v':
> Qt: 3.3.1
> KDE: 3.2.1
> KMail: 1.6.2

IMHO KMail is trying to emulate too many bad things from Windows mailers.

> I viewed the source of my previous message and I have to agree: Bleah!!
>
> What mailer whould you suggest? What mailer do you use?

Ah, well, I use emacs; it's really convenient to be able to read your
mail and edit source code from within the same application. But
please use whatever you're comfortable with.

> In the Settings, I see I have a choice between "Allow 8-bit" or
> "MIME Compliant (Quoted Printable)". For this message I used "Allow
> 8-bit". I hope this does a better job. If not, I'll have to change
> mailers.

Yes it is. And it seems most MTA's are 8-bit clean these days. It's
a bit sad you don't get offered the possibility to use 7-bit ASCII :(

> I thought MIME was the standard though. Is that not the case?

Sort of. But I think it should only used for binary attachments; not
simple text messages.

> Also, the attachment on my previous message claims to be
> "text/x-diff". I changed this one to "text/plain". Did that make
> any difference for you?

Yup; it's much more readable that way.

> I really appreciate your help in getting all this stuff 'right'.

Thnaks for putting up with me ;-). I'm sure you get it more "right"
from the start next time.

Mark