From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16771 invoked by alias); 2 Dec 2005 19:56:46 -0000 Received: (qmail 16760 invoked by uid 22791); 2 Dec 2005 19:56:46 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Dec 2005 19:56:44 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id jB2Ju8PI010046; Fri, 2 Dec 2005 20:56:08 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id jB2Ju7NO003465; Fri, 2 Dec 2005 20:56:07 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id jB2Ju5YN000928; Fri, 2 Dec 2005 20:56:05 +0100 (CET) Date: Fri, 02 Dec 2005 20:28:00 -0000 Message-Id: <200512021956.jB2Ju5YN000928@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pgilliam@us.ibm.com CC: jimb@red-bean.com, gdb-patches@sources.redhat.com In-reply-to: <200512021120.22263.pgilliam@us.ibm.com> (message from Paul Gilliam on Fri, 2 Dec 2005 11:20:22 -0800) Subject: Re: [PATCH] add 'rs6000_in_function_epilogue_p()' (Revised) References: <200511301225.56802.pgilliam@us.ibm.com> <8f2776cb0512011707p120df411w3a685c453d4ec625@mail.gmail.com> <200512021120.22263.pgilliam@us.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00065.txt.bz2 > From: Paul Gilliam > Date: Fri, 2 Dec 2005 11:20:22 -0800 > > And here is the revised patch: > > 2005-12-02 Paul Gilliam > > * rs6000-tdep.c: Add new subroutine, 'rs6000_in_function_epilogue_p()' > and put it into the architecture vector. Paul, There are a couple of problems with your patch. Please read read the GNU condig standards http://www.gnu.org/prep/standards/. Here are a fuw issues: * Please put a space before the ( that starts the functions arguments. * ins_changes_sp contains unused variables. Please configure gdb with --enable-gdb-build-warnings=,-Werror, this'll prevent them from slipping through. * Please don't make your lines too long. The emacs default fill-column is 72, but in general we tolerate lines that are a bit longer. But make sure the line ends before column 79/80. * "break" should be put on a line of its own. * Always surround =, -=, etc. with spaces. I think your patch should go in. But it's really Andrew Cagney's and Kevin Buettner's call. Mark