From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32010 invoked by alias); 2 Dec 2005 17:47:26 -0000 Received: (qmail 31994 invoked by uid 22791); 2 Dec 2005 17:47:26 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Dec 2005 17:47:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id jB2HlNKa032213 for ; Fri, 2 Dec 2005 12:47:23 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id jB2HlMV31293 for ; Fri, 2 Dec 2005 12:47:22 -0500 Received: from localhost.localdomain (vpn50-83.rdu.redhat.com [172.16.50.83]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id jB2HlMT6018334 for ; Fri, 2 Dec 2005 12:47:22 -0500 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id jB2HlHMU013659 for ; Fri, 2 Dec 2005 10:47:17 -0700 Date: Fri, 02 Dec 2005 18:28:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [patch] Add ms2 support Message-ID: <20051202104716.1ab85b4d@ironwood.lan> In-Reply-To: <438EFD86.6060306@codesourcery.com> References: <438EFD86.6060306@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00056.txt.bz2 On Thu, 01 Dec 2005 13:41:26 +0000 Nathan Sidwell wrote: > * ms1-tdep.c (ms1_register_type): Check for ms2. > (ms1_breakpoint_from_pc): ms2 has a different break instruction. > (ms1_pseudo_register_read, ms1_pseudo_register_write, > ms1_registers_info): Add ms2. This is okay. (I would have preferred to see the reformatting changes in ms1_registers_info() go into a separate patch.) Kevin