From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12807 invoked by alias); 30 Nov 2005 19:03:21 -0000 Received: (qmail 12798 invoked by uid 22791); 30 Nov 2005 19:03:20 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 30 Nov 2005 19:03:16 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EhXEV-0006ee-OB; Wed, 30 Nov 2005 14:03:11 -0500 Date: Wed, 30 Nov 2005 23:01:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [PATCH] init-if-undefined command Message-ID: <20051130190311.GA25377@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , Jim Blandy , gdb-patches@sources.redhat.com References: <437B3E56.3080306@st.com> <8f2776cb0511292141t2f9711a2l9633236db737e67b@mail.gmail.com> <438DB351.2050500@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <438DB351.2050500@st.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00514.txt.bz2 On Wed, Nov 30, 2005 at 02:12:33PM +0000, Andrew STUBBS wrote: > + printf_unfiltered ("Init-if-undefined requires an assignment expression.\n"); Is there any reason this, and the other outputs, should not be _("gettextized")? Also, should this be an error()? > + /* Extract the variable from the parsed expression. > + In the case of an assign the lvalue will be in elts[1] and elts[2]. */ > + if (expr->elts[1].opcode != OP_INTERNALVAR) > + { > + printf_unfiltered ("The first parameter to init-if-undefined should be a GDB variable\n"); > + do_cleanups (old_chain); > + return; > + } Ditto. -- Daniel Jacobowitz CodeSourcery, LLC