Re: [RFC] DW_CFA_restore handling causes memory fault

Jim Blandy
2005-11-18T08:35:25Z

On 11/18/05, Frederic RISS <frederic.riss@st.com> wrote:
> > Right; we're supposed to be prepared for mis-formed input. It would
> > be nice to have a brief comment explaining that the 'else' half of the
> > 'if' does constitute questionable behavior on the part of the
> > compiler.
>
> Like in the attached patch ?

Yes! But --- I apologize for not noticing this from the beginning ---
as I see your comment, it occurs to me that probably a call to
'complaint' would be better than just a comment. Mark or Daniel can
string me up if they feel this will yield another 'incomplete CFI
data; unspecified blah blah blah' annoyance, but I think it's probably
the right thing.

With this change, I think it's okay to commit, so let's get the
paperwork out of the way. If you're doing this as part of your paying
job, then the assignment from STMicroelectronics already on file
covers your work, so you just need to get an account on
sourceware.org, add yourself to the "write after approval" list in
gdb/MAINTAINERS, and then you can commit the change.

For the sourceware account, see
http://sourceware.org/cgi-bin/pdw/ps_form.cgi. List me as the person
approving the request.