From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22835 invoked by alias); 17 Nov 2005 10:49:09 -0000 Received: (qmail 22825 invoked by uid 22791); 17 Nov 2005 10:49:06 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 17 Nov 2005 10:49:06 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id jAHAn4BV016559; Thu, 17 Nov 2005 11:49:04 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id jAHAn3N3001575; Thu, 17 Nov 2005 11:49:03 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id jAHAn3kx001850; Thu, 17 Nov 2005 11:49:03 +0100 (CET) Date: Thu, 17 Nov 2005 12:17:00 -0000 Message-Id: <200511171049.jAHAn3kx001850@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: randolph@tausq.org CC: gdb-patches@sources.redhat.com In-reply-to: <437C55B8.1070604@tausq.org> (message from Randolph Chung on Thu, 17 Nov 2005 18:04:40 +0800) Subject: Re: [hppa-hpux] Signal frame unwinding support for hppa64-hp-hpux11.11 References: <437C0B76.7010109@tausq.org> <200511170956.jAH9uXfn030506@elgar.sibelius.xs4all.nl> <437C55B8.1070604@tausq.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00271.txt.bz2 > Date: Thu, 17 Nov 2005 18:04:40 +0800 > From: Randolph Chung > > >>2005-11-15 Randolph Chung > >> > >> * hppa-hpux-tdep.c (hppa_hpux_sigtramp_frame_unwind_cache): Ensure "off" > >> is large enough to hold 64-bit offset. Set proper signal context offset > >> for 64-bit programs. Set pc properly for signal frames. > > > > > > Please reformat the ChangeLog entry before you commit; the lines are too long! > > I can, but these lines are only 80 characters wide... why are they too > long? Ah, 80 characters is too long. Emacs will wrap the line if there's something in column 80. Please keep it down to something like 72. > >>Index: hppa-hpux-tdep.c > >>=================================================================== > >>RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v > >>retrieving revision 1.43 > >>diff -u -p -r1.43 hppa-hpux-tdep.c > >>--- hppa-hpux-tdep.c 29 Oct 2005 21:31:45 -0000 1.43 > >>+++ hppa-hpux-tdep.c 15 Nov 2005 15:40:07 -0000 > >>@@ -1188,7 +1192,7 @@ hppa_hpux_sigtramp_frame_unwind_cache (s > >> else > >> { > >> /* Wide registers. */ > >>- off = scptr + offsetof (save_state_t, ss_wide) + 8; > >>+ off = scptr + offsetof (save_state_t, ss_wide.ss_64) + 8; > >> incr = 8; > >> szoff = (tdep->bytes_per_address == 4 ? 4 : 0); > >> } > >>@@ -1203,11 +1207,15 @@ hppa_hpux_sigtramp_frame_unwind_cache (s > > > > > > Hmm, why is this chunk needed? AFAICT it shouldn't make a difference > > and I have a preference for using a plain ss_wide). > > It's not needed, but it's a bit clearer IMO. I will revert this if you > prefer. Actually what I'd really prefer if you'd make use of the HPPA_HPUX_SS_XXX constants that I added when I did the HP-UX register set support. You'll need to move them to the start of the file, but using them would bring us a step closer to building a HP-UX cross-debugger. But if you don't want to spend the time on this, then yes, I'd prefer that you don't change ss_wide into ss_wide.ss_64. The reason is actually that even for 32-bit stuff the ss_wide part of save_state_t might be used. So I think the ss_64 part is misleading. Mark