Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: randolph@tausq.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [hppa-hpux] Signal frame unwinding support for hppa64-hp-hpux11.11
Date: Thu, 17 Nov 2005 11:48:00 -0000	[thread overview]
Message-ID: <200511170956.jAH9uXfn030506@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <437C0B76.7010109@tausq.org> (message from Randolph Chung on Thu, 17 Nov 2005 12:47:50 +0800)

> Date: Thu, 17 Nov 2005 12:47:50 +0800
> From: Randolph Chung <randolph@tausq.org>
> 
> The attached patch adds support for signal frame unwinding under
> hppa64-hp-hpux11.11, and fixes a bug with signal frame unwinding under
> hppa2.0w-hp-hpux11.11. I will commit this in a day or no if there are no
> comments.
> 
> 2005-11-15  Randolph Chung  <tausq@debian.org>
> 
> 	* hppa-hpux-tdep.c (hppa_hpux_sigtramp_frame_unwind_cache): Ensure "off"
> 	is large enough to hold 64-bit offset.  Set proper signal context offset
> 	for 64-bit programs.  Set pc properly for signal frames.

Please reformat the ChangeLog entry before you commit; the lines are too long!

> Index: hppa-hpux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v
> retrieving revision 1.43
> diff -u -p -r1.43 hppa-hpux-tdep.c
> --- hppa-hpux-tdep.c	29 Oct 2005 21:31:45 -0000	1.43
> +++ hppa-hpux-tdep.c	15 Nov 2005 15:40:07 -0000
> @@ -1188,7 +1192,7 @@ hppa_hpux_sigtramp_frame_unwind_cache (s
>    else
>      {
>        /* Wide registers. */
> -      off = scptr + offsetof (save_state_t, ss_wide) + 8;
> +      off = scptr + offsetof (save_state_t, ss_wide.ss_64) + 8;
>        incr = 8;
>        szoff = (tdep->bytes_per_address == 4 ? 4 : 0);
>      }
> @@ -1203,11 +1207,15 @@ hppa_hpux_sigtramp_frame_unwind_cache (s

Hmm, why is this chunk needed?  AFAICT it shouldn't make a difference
and I have a preference for using a plain ss_wide).

Mark


  reply	other threads:[~2005-11-17  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-17 11:28 Randolph Chung
2005-11-17 11:48 ` Mark Kettenis [this message]
2005-11-17 12:10   ` Randolph Chung
2005-11-17 12:17     ` Mark Kettenis
2005-11-17 12:44       ` Randolph Chung
2005-11-17 12:56         ` Mark Kettenis
2005-11-19 18:58           ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511170956.jAH9uXfn030506@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox