From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31420 invoked by alias); 17 Nov 2005 03:48:15 -0000 Received: (qmail 31413 invoked by uid 22791); 17 Nov 2005 03:48:14 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 17 Nov 2005 03:48:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Ecakt-0000qN-Uq; Wed, 16 Nov 2005 22:48:12 -0500 Date: Thu, 17 Nov 2005 04:22:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Disable thread specific breakpoints when thread dies Message-ID: <20051117034811.GB3057@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , gdb-patches@sources.redhat.com References: <43723446.7000903@st.com> <20051113184515.GG3599@nevyn.them.org> <437875B0.4000007@st.com> <20051114155659.GA25717@nevyn.them.org> <437A19DE.6040905@st.com> <437B47A1.4040705@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <437B47A1.4040705@st.com> User-Agent: Mutt/1.5.8i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00263.txt.bz2 On Wed, Nov 16, 2005 at 02:52:17PM +0000, Andrew STUBBS wrote: > + /* There is no point inserting thread-specific breakpoints if the > + thread no longer exists. */ > + if (b->owner->thread != -1 > + && !target_thread_alive(thread_id_to_pid(b->owner->thread))) > + continue; You shouldn't need to use the target method here. Does valid_thread_id work? Also, please remember the space before opening parentheses. -- Daniel Jacobowitz CodeSourcery, LLC