From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21804 invoked by alias); 30 Oct 2005 23:32:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21292 invoked by uid 22791); 30 Oct 2005 23:32:28 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 30 Oct 2005 23:32:28 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EWMf1-0000Lc-JG; Sun, 30 Oct 2005 18:32:23 -0500 Date: Mon, 31 Oct 2005 11:56:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: PATCH: Fix TUI null pointer dereference Message-ID: <20051030233223.GB1155@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , Jim Blandy , gdb-patches@sources.redhat.com References: <4353B4A5.3010209@st.com> <435CE1E7.4040803@st.com> <435D20E0.6040504@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <435D20E0.6040504@st.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-10/txt/msg00227.txt.bz2 On Mon, Oct 24, 2005 at 06:58:56PM +0100, Andrew STUBBS wrote: > Jim Blandy wrote: > >We generally avoid using assignments directly as conditions. Just > >hoist the assignment out and just say 'if (term)'. With that change, > >feel free to commit. > > OK. Here is an updated patch. > > I do not have write permission/ability. If I could get that set up that > would be great, but till then somebody else wil have to submit it for me > please. You've got lots of pending patches (that I was going to review this weekend but ran out of time... it will get done this week). So, let's get you write access. Go to sourceware.org, look for the link that says "handy dandy little form", and list me as approver. It looks like ST has corporate assignments in place, so there won't be any trouble on that front. -- Daniel Jacobowitz CodeSourcery, LLC