Re: PATCH: Problem union comparision in TUI

Daniel Jacobowitz
2005-10-21T16:39:30Z

On Fri, Oct 21, 2005 at 03:52:55PM +0100, Andrew STUBBS wrote:
> Eli Zaretskii wrote:
> >I still think that adding a tag to the union is the cleanest solution.
>
> I have attached a patch implementing this. I have also attached a
> slightly improved version of the one I posted before.
>
> I am not entirely happy with the tagged union approach. There are a
> number of places where it just assumes that the union must be doing the
> right thing here. The only other possibility would be to assert. It
> does, however, solve the problem at hand.
>
> Does either of these grab your fancy?

Don't we always know what window the compared quantities belong to?
Isn't which is in use a static property of the window type? i.e. isn't
that a pre-existing "tag" for the union?

--
Daniel Jacobowitz
CodeSourcery, LLC