Re: [PATCH] Relative source file search

Craig Jeffree
2005-10-06T23:33:50Z

On Thu, 2005-10-06 at 09:00 -0400, Bob Rossi wrote:
> Yes, this makes sense. Basically, the dirname is simply added to the
> source path, nothing else is done with it. AFAIK, the symtab will have
> the filename be what you gave to it on the compile line. For example,
> 'gcc -g ../main.c -o main' will give a filename of '../main.c', and if
> you do 'gcc -g main.c -o main', it will give a filename of 'main.c'.
> However, I'm not an expert on this.

I wonder how this works with header files, in my application for some
reason the filename ends up being split into dirname (the relative path
bit) and filename (just the actual filename). However in a little test
case I tried to make to reproduce it I ended up with an empty dirname
and the whole relative path+filename in filename. It's only the former
case that causes problems.

> Here's the current order looking for foo.c with
> dirname of '../src'
>
> 1. Look for foo.c
> 2. For each source_path, Look for source_path[i]/foo.c
>
> This case will search for 'foo.c' and '../src/foo.c'.
>
> The new search would be something like,
>
> 1. Look for foo.c
> 2. For each source_path, Look for source_path[i]/foo.c
> 3. Look for ../src/foo.c /* Not needed */
> 4. For each source_path, Look for source_path[i]/../src/foo.c
>
> This case will search for 'foo.c', '../src/foo.c', '../src/foo.c'
> and source_path[i]/../src/foo.c. The 3 case isn't needed, since it
> will be searched for in the second case.
>
> Is this what you are suggesting to change?

Not quite. I'm proposing "If dirname is absolute behave as it does now,
if dirname is relative prepend it to filename and treat dirname as
empty". This gives the new search from your example above to be...

1. Look for ../src/foo.c
2. For each source_path, Look for source_path[i]/../src/foo.c

I believe this is how it already behaves in all cases where the symtab
contains an empty dirname and a relatively pathed filename. Ideally we
should have consitent behaviour for the case where the relative path bit
is in dirname.

Cheers,
Craig.