From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jimb@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Relax checking of garbage struct return values
Date: Sun, 09 Oct 2005 20:32:00 -0000 [thread overview]
Message-ID: <200510092032.j99KWGYO030371@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <m31x2ybkw2.fsf@alligator.red-bean.com> (message from Jim Blandy on Thu, 06 Oct 2005 10:44:29 -0700)
> From: Jim Blandy <jimb@redhat.com>
> Date: Thu, 06 Oct 2005 10:44:29 -0700
>
> The comments are supposed to have the story. Tested on
> x86_64-pc-linux-gnu.
>
> 2005-10-05 Jim Blandy <jimb@redhat.com>
>
> * gdb.base/structs.exp (any): New function.
> (test_struct_returns): Don't make any assumptions at all about
> what value the function returns when GDB can't set the return
> value.
I remember having a discussion about this with Andrew some time ago.
I believe Andrew argued that if the compiler doesn't pass L<n> as the
buffer, this should be considered a compiler bug.
Anyway, there is another case where things fail. Some compilers use a
"static" buffer to store function values. On those systems these
tests fail too.
I think your patch is ok: gdb is not a compiler testsuite.
Mark
next prev parent reply other threads:[~2005-10-09 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 20:38 Jim Blandy
2005-10-09 20:30 ` Daniel Jacobowitz
2005-10-09 20:32 ` Mark Kettenis [this message]
2005-10-12 17:53 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510092032.j99KWGYO030371@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox