From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9905 invoked by alias); 3 Oct 2005 21:23:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9893 invoked by uid 22791); 3 Oct 2005 21:23:43 -0000 Received: from s142-179-108-108.bc.hsia.telus.net (HELO takamaka.act-europe.fr) (142.179.108.108) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 03 Oct 2005 21:23:43 +0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 343AE47E74; Mon, 3 Oct 2005 14:23:41 -0700 (PDT) Date: Mon, 03 Oct 2005 21:23:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA] print arrays with indexes Message-ID: <20051003212341.GG8849@adacore.com> References: <20050920193132.GY2496@adacore.com> <20050920193339.GA28294@nevyn.them.org> <20050920193918.GB10186@adacore.com> <20050922164622.GF5841@adacore.com> <20050926012259.GA22284@nevyn.them.org> <20050927010420.GW922@adacore.com> <20051002224218.GA3083@nevyn.them.org> <20051003061733.GL938@adacore.com> <20051003155019.GA23854@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051003155019.GA23854@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-10/txt/msg00028.txt.bz2 > A comment would be nice. With that change, the patch (and testcase and > docs) are OK. Thank you. Here is the comment I added: Computing the array lower bound is pretty easy, but this function does some additional verifications before returning the low bound. If something incorrect is detected, it is better to return a status rather than throwing an error, making it easier for the caller to implement an error-recovery plan. For instance, it may decide to warn the user that the bound was not found and then use a default value instead. */ It occurs to me that we might eventually want to move this function somewhere more general, add a parameter for the upper bound, and use it everywhere... Some thoughts for a rainy day... Patch checked in. Currently working on the testcase and doc. Thanks, -- Joel