From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14051 invoked by alias); 2 Oct 2005 22:42:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14041 invoked by uid 22791); 2 Oct 2005 22:42:22 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 02 Oct 2005 22:42:22 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EMCXC-0000u7-KB; Sun, 02 Oct 2005 18:42:18 -0400 Date: Sun, 02 Oct 2005 22:42:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] print arrays with indexes Message-ID: <20051002224218.GA3083@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050918191943.GA27191@nevyn.them.org> <20050920073058.GR2496@adacore.com> <20050920193132.GY2496@adacore.com> <20050920193339.GA28294@nevyn.them.org> <20050920193918.GB10186@adacore.com> <20050922164622.GF5841@adacore.com> <20050926012259.GA22284@nevyn.them.org> <20050927010420.GW922@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050927010420.GW922@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-10/txt/msg00006.txt.bz2 On Mon, Sep 26, 2005 at 06:04:20PM -0700, Joel Brobecker wrote: > BTW: I think you are using vim, IIRC. Do you have some magic settings > that handles that handles the tabs for you. If I were able to have tabs > automatically created after I create spaces, and also transformed into > spaces when I backspace into them, as well as allowing me to go through > them as if they were spaces, I wouldn't mind the tabs so much. No, sorry; I use a bastard combination of emacs and joe for most of my code editing. Can't help you with Vim. > + if (TYPE_CODE (index) == TYPE_CODE_RANGE) > + index = TYPE_TARGET_TYPE (index); > > which the function used to have. I couldn't understand why this > was necessary, and a look at where the type was used showed that > this was not necessary, as ada_print_scalar, the only eventual consumer > of that type, knew how to handle range types. I would think the same is > true of all other languages, right? Not sure what you mean by "used to have", to be honest. I guess this code had some prior life in an ACT tree, if you didn't write it? It seems like the sort of check that only Ada would need. And, this code is still in the patch below. It's definitely dead code, though, so I assume you meant to remove it. Should the "return 0;" cases in get_array_low_bound be errors? Or even internal errors (probably not)? There's already lots of code that uses TYPE_LOW_BOUND (TYPE_INDEX_TYPE (array_type)). If that's not valid, we need to know why not. -- Daniel Jacobowitz CodeSourcery, LLC