From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31302 invoked by alias); 2 Oct 2005 21:05:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31261 invoked by uid 22791); 2 Oct 2005 21:05:08 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 02 Oct 2005 21:05:08 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EMAx3-0008Vo-Dg; Sun, 02 Oct 2005 17:00:53 -0400 Date: Sun, 02 Oct 2005 21:05:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Decimal Floating Point support for GDB (Part 2: testcase) Message-ID: <20051002210053.GA32664@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-10/txt/msg00002.txt.bz2 On Wed, Sep 28, 2005 at 01:28:07PM +0800, Wu Zhou wrote: > In this testcase, there are totally 83 tests. Most of them are about > displaying and setting of dfp types, which are partitioned into > three groups, one for each dfp types (_Decimal32, _Decimal64 and > _Decimal128). In each group, we first begin with the printing of > a normal finite dfp value, then Infinity and NaN. Then we call > d32_set_tests (d64_set_tests or d128_set_tests) to test that GDB > could handle the setting different values of variable d32 (d64 or > d128). > > At the end of the testcase, we test that GDB could print out the dfp > values correctly in the function arguments and backtrace. Just a few comments on the tests: - This should be at least two separate tests, since the "p 1.5df" tests can be run without a GCC which supports DFP, even though dfp-test.c can't be compiled. - C files need to have copyright headers. In this: > + gdb_test "p d32=123.45df" "123.45df" "p d32=123.45df" - The third argument to gdb_test defaults to the first argument, so you don't need it. - The second argument should be more specific. Something like "\$${decimal} = 123.45df". I went to look at this test to see if my understanding of the use of string types was right, and the matching patterns were so loose I couldn't tell. Otherwise I'll wait to look at this further until we're agreed on the GDB support. -- Daniel Jacobowitz CodeSourcery, LLC