Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging

Andreas Schwab
2005-09-27T22:57:25Z

Daniel Jacobowitz <drow@false.org> writes:

> Which test failures are these? i.e. why doesn't anyone else see this
> when they run the testsuite?

I've somehow lost the log files and had to rerun the testsuite, and now I
no longer see any difference in the test results.

> Offhand I'd be suspicious that this helped - some other thread probably
> needs its PC adjusted and now may not be.

The patch will never result in less adjustments, because the other arm of
the conditional will do the adjustment anyway if a breakpoint exists at
the current PC. Note that prev_pc is also part of the thread context and
may be wrong for the current thread as well.

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃŸe 5, 90409 NÃ¼rnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."