Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging

Daniel Jacobowitz
2005-09-28T14:59:21Z

On Wed, Sep 28, 2005 at 12:57:16AM +0200, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@false.org> writes:
>
> > Which test failures are these? i.e. why doesn't anyone else see this
> > when they run the testsuite?
>
> I've somehow lost the log files and had to rerun the testsuite, and now I
> no longer see any difference in the test results.
>
> > Offhand I'd be suspicious that this helped - some other thread probably
> > needs its PC adjusted and now may not be.
>
> The patch will never result in less adjustments, because the other arm of
> the conditional will do the adjustment anyway if a breakpoint exists at
> the current PC. Note that prev_pc is also part of the thread context and
> may be wrong for the current thread as well.

Can you describe whatever testcase prompted you to make this change?
Is there some way we can reproduce the situation?

I've been looking this morning at a (probably unrelated) bug which
would probably vanish if this patch were applied, but which was really
triggered by an uninitialized variable in infrun. More to come once
I've tested.