Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: gdb-patches@sources.redhat.com
Subject: Fix PR1659
Date: Wed, 28 Sep 2005 07:41:00 -0000	[thread overview]
Message-ID: <20050928074118.GL29044@bubble.grove.modra.org> (raw)

Obvious fixes.  OK to apply?

	PR 1659
	* rs6000-tdep.c (rs6000_push_dummy_call): Correct size of
	backchain write.
	(rs6000_convert_from_func_ptr_addr): Correct comment

Index: gdb/rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.243
diff -u -p -r1.243 rs6000-tdep.c
--- gdb/rs6000-tdep.c	19 Sep 2005 17:38:03 -0000	1.243
+++ gdb/rs6000-tdep.c	28 Sep 2005 07:36:48 -0000
@@ -1629,8 +1629,8 @@ ran_out_of_registers_for_arguments:
   regcache_raw_write_signed (regcache, SP_REGNUM, sp);
 
   /* Set back chain properly.  */
-  store_unsigned_integer (tmp_buffer, 4, saved_sp);
-  write_memory (sp, tmp_buffer, 4);
+  store_unsigned_integer (tmp_buffer, wordsize, saved_sp);
+  write_memory (sp, tmp_buffer, wordsize);
 
   /* Point the inferior function call's return address at the dummy's
      breakpoint.  */
@@ -2241,13 +2241,13 @@ rs6000_create_inferior (int pid)
 
    Usually a function pointer's representation is simply the address
    of the function. On the RS/6000 however, a function pointer is
-   represented by a pointer to a TOC entry. This TOC entry contains
+   represented by a pointer to an OPD entry. This OPD entry contains
    three words, the first word is the address of the function, the
    second word is the TOC pointer (r2), and the third word is the
    static chain value.  Throughout GDB it is currently assumed that a
    function pointer contains the address of the function, which is not
    easy to fix.  In addition, the conversion of a function address to
-   a function pointer would require allocation of a TOC entry in the
+   a function pointer would require allocation of an OPD entry in the
    inferior's memory space, with all its drawbacks.  To be able to
    call C++ virtual methods in the inferior (which are called via
    function pointers), find_function_addr uses this function to get the

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


             reply	other threads:[~2005-09-28  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28  7:41 Alan Modra [this message]
2005-10-02 22:27 ` Daniel Jacobowitz
2005-10-06  0:39   ` Alan Modra
2005-10-06  0:41     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050928074118.GL29044@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox