Re: [RFA] print arrays with indexes

Joel Brobecker
2005-09-20T19:31:44Z

> > 1. If array size > threshold, then print indexes
> > 2. If array size < threshold, then print indexes
>
> The second, I think: it makes sense to ask for arrays that are not too
> large to be printed with additional info.

This is fine with me.

> > Now, the sticky part: How to implement this new interface.
> >
> > I'll argue that it's best to implement something new. I don't like
> > hijacking an old interface to unsigned integer and adding some aliases
> > to a couple of values. My reasoning is that saying that OFF is an alias
> > for UINT_MAX will make sense for certain cases while it actually won't
> > for other cases. Actually, which value to use for OFF will depend on
> > the what the threashold actually means.
>
> If you accept my view above, then threshold value of zero means
> unlimited. We already have several set/show commands that behave this
> way, so I don't see any problem with having yet another.

Well, looks like you are now suggesting that we drop the idea of having
on/off aliases, to which I disagree. How about people like me who want
this feature OFF all the time, except in rare occasions?

> > I vote for a new API.
>
> I don't see any reason for a new API.

If you accept my view on the necessity of having on/off values instead
of just controlling this feature with a plain integer, then maybe we
have a more compelling reason?

> > I think we should also review the usage of the current ones, probably
> > cleanup a bit some of the ones that were on the road to obsolescence
> > (IIRC), maybe rationalize a bit more our API if needed, and add some
> > documentation. But that should be a separate thread. I don't think I
> > will be able to handle all of this, but I can certainly help.
>
> That sounds like a lot of unnecessary work for such an obscure
> feature, IMHO.

To me, it's totally unrelated to what we are discussing. It's just
a idea that popped up during the course of this discussion. You
said that our current API for set/show commands is poorly documented.
Daniel and I offer to look into the documentation problem, and I also
suggest that this is a good time to do any cleanup if needed.

--
Joel