From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18272 invoked by alias); 18 Sep 2005 01:39:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18206 invoked by uid 22791); 18 Sep 2005 01:39:06 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 18 Sep 2005 01:39:06 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EGo91-00008g-Sc; Sat, 17 Sep 2005 21:39:03 -0400 Date: Sun, 18 Sep 2005 01:39:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch Ping]: the support of F90 subarray and substring evaluation Message-ID: <20050918013903.GT8777@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00145.txt.bz2 On Mon, Aug 15, 2005 at 10:07:58PM +0800, Wu Zhou wrote: > 2005-08-15 Wu Zhou > > * expression.h (enum exp_opcode): Add a new operator for F90 > subrange. > * f-lang.h (enum f90_range_type): New enumeration type to identify > F90 subrange type. > * f-exp.y (yyparse): Add support for parsing F90 subrange and > change substring parsing to subrange parsing. > * parse.c (operator_length_standard): Set the operator length > and args number for OP_F90_RANGE. > * eval.c (evaluate_subexp_standard): Add code to evaluate F90 > array section and substring. > (value_f90_subarray): New function to evaluate F90 array section. > (label op_f77_substr): Replaced by value_f90_subarray. Deleted. Sorry about the delay. This patch, and the testsuite patch, are OK. Two formatting comments to clean up before you check it in: Don't reference "label op_f77_substr" as if it were a function in the ChangeLog. Reference the containing function, instead. > + /* A F90 array range operator. (for "exp:exp", "exp:", ":exp" and ":") */ /* A F90 array range operator (for "exp:exp", "exp:", ":exp" and ":"). */ Period at the end and two spaces. Thanks! > 2005-08-15 Wu Zhou > > * gdb.fortran/subarray.exp: New testcase to test the evaluation > of subarray and substring variable. > * gdb.fortran/subarray.f: New source file for the test of subarray > and substring variable evaluation. > * gdb.fortran/exprs.exp: Add four tests for substring evaluation > of string constant. -- Daniel Jacobowitz CodeSourcery, LLC