From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11300 invoked by alias); 18 Sep 2005 01:14:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11289 invoked by uid 22791); 18 Sep 2005 01:14:17 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 18 Sep 2005 01:14:17 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EGnkz-0008ND-V2; Sat, 17 Sep 2005 21:14:14 -0400 Date: Sun, 18 Sep 2005 01:14:00 -0000 From: Daniel Jacobowitz To: Shaun Jackman Cc: Richard Earnshaw , gdb-patches@sources.redhat.com Subject: Re: sim/arm/armos.c: IsTTY [PATCH] Message-ID: <20050918011413.GO8777@nevyn.them.org> Mail-Followup-To: Shaun Jackman , Richard Earnshaw , gdb-patches@sources.redhat.com References: <7f45d9390508151204ca0b146@mail.gmail.com> <20050830023718.GB16189@nevyn.them.org> <7f45d93905090709516f912861@mail.gmail.com> <1126170388.18092.16.camel@pc960.cambridge.arm.com> <7f45d93905090910237c63acf0@mail.gmail.com> <20050917223728.GL8777@nevyn.them.org> <7f45d939050917163241caaa41@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f45d939050917163241caaa41@mail.gmail.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00139.txt.bz2 It only now occurs to me to ask if you have a copyright assignment on file with the FSF - do you? I don't see one listed. Sorry for not catching this potential problem earlier. On Sat, Sep 17, 2005 at 05:32:30PM -0600, Shaun Jackman wrote: > +static int > +ReadFileName(ARMul_State *state, char *buf, ARMword src, size_t n) Space before the parens here. > +{ > + struct OSblock *OSptr = (struct OSblock *) state->OSptr; > + char *p = buf; > + > + while (n--) > + if ((*p++ = ARMul_SafeReadByte (state, src++)) == '\0') > + return 0; > + OSptr->ErrorNo = cb_host_to_target_errno(sim_callback, ENAMETOOLONG); > + return state->Reg[0] = -1; I'd appreciate it if you didn't use the return value of assignment this way; it's too easy to assume a typo. > + if (ReadFileName(state, buf, path, sizeof buf) != -1) > + { Space before parens, braces get indented. > + if (ReadFileName(state, oldbuf, old, sizeof oldbuf) != -1 && > + ReadFileName(state, newbuf, new, sizeof newbuf) != -1) And operators go at the beginning of the line. Looks odd at first, but you get used to it. -- Daniel Jacobowitz CodeSourcery, LLC