Re: sim/arm/armos.c: IsTTY [PATCH]

Daniel Jacobowitz
2005-09-18T02:59:12Z

On Sat, Sep 17, 2005 at 08:40:14PM -0600, Shaun Jackman wrote:
> 2005/9/17, Daniel Jacobowitz <drow@false.org>:
> > It only now occurs to me to ask if you have a copyright assignment on
> > file with the FSF - do you? I don't see one listed. Sorry for not
> > catching this potential problem earlier.
>
> No, I haven't. I'll reply privately with a fax number if that's
> possible. Otherwise, I'll give you my address for mashed-tree
> correspondance.

I'll follow up off-list for this bit.

> > Space before the parens here.

Missed one of these:

> + OSptr->ErrorNo = cb_host_to_target_errno(sim_callback, ENAMETOOLONG);

No need to repost the patch for this. Otherwise, it looks fine to me.

--
Daniel Jacobowitz
CodeSourcery, LLC