From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: qpan@mvista.com, gdb-patches@sources.redhat.com, qunyingpan@gmail.com
Subject: Re: Patch: fix gdb_gcore.sh failure in ash/dash
Date: Sat, 17 Sep 2005 22:18:00 -0000 [thread overview]
Message-ID: <200509172217.j8HMHh3R005674@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20050917215830.GG8777@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 17 Sep 2005 17:58:30 -0400)
> Date: Sat, 17 Sep 2005 17:58:30 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> On Fri, Sep 09, 2005 at 07:11:13PM -0700, Qunying Pan wrote:
> > Hi,
> >
> > Running gdb_gcore.sh in ash/dash fails with message "Hangup detected on
> > fd 0". The following patch fixes the problem. Acceptable?
>
> Let's just use a tempfile. This patch also makes one other change in
> behavior: it uses gdb from $PATH instead of hardcoding /usr/bin, since
> I needed that to test it and it seems more reasonable.
>
> Anyone have comments on this patch?
I think using a temporary file is a good idea, but if I read your
patch correctly, it seems the temporary file is created in the current
directory, which might not be writable.
Another problem is that the name is predictable, which is a potential
security risk. Assuming mktemp(1) is available is probably not a good
idea, but it'd be nice to use it if it's avaiable.
Mark
next prev parent reply other threads:[~2005-09-17 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 2:18 Qunying Pan
2005-09-11 1:12 ` Michael Snyder
2005-09-11 4:35 ` Daniel Jacobowitz
2005-09-11 21:37 ` Qunying Pan
2005-09-11 21:19 ` Mark Kettenis
2005-09-11 23:08 ` Daniel Jacobowitz
2005-09-17 21:58 ` Daniel Jacobowitz
2005-09-17 22:18 ` Mark Kettenis [this message]
2005-09-17 22:27 ` Daniel Jacobowitz
2005-09-26 1:52 ` Daniel Jacobowitz
2005-09-26 7:20 ` Mark Kettenis
2005-10-02 23:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509172217.j8HMHh3R005674@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=qpan@mvista.com \
--cc=qunyingpan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox