On Friday 09 September 2005 16:33, Paul Gilliam wrote:
> The "Info powerpc" command has no subcommands and does nothing.
> 
> The testsuit tests "info powerpc altivec"
> 
> So, should I depreciate 'info powerpc', just get rid of it, or add the 'altivec' subcommand and just point it to 'info vector'?
> 
> -=# Paul #=-
> 
> 

Attached are three patches, each a different way to deal with this problem:

The first is 'easy_altivec.patch'.  It adds the "info powerpc altivec" sub-command and has it call the same
routine as "info vector" does.  The only down-side is that the routine 'vector_info' in infcmd.c has to be made global.

The second, 'altivec_alias.patch', functions like the first, except that infcmd.c is not touched.  Instead, an 'info powerpc altivec' command
is added that turns itself into an alias for "info vector" the first time it's called.  This can't be done with add_com_alias because the alias and 
the command being aliased are on different command chains.

The final patch, 'no_more_altivec.patch' depreciates the "info powerpc" command prefix and changes the testsuite to use "info vector".  To make
this work, 'lookup_cmd_composition' in cli/cli-decode.c had to be changed so that a prefix command that has no sub-commands
can be depreciated.

My personel favorite is the first one.  It does the right thing while leaving "info powerpc" useable for other sub-commands.  And it's simple.

My second favorite is the second one.  It's like the first, except only the rs6000-tdep.c file need be changed.  Well, maybe it's not so simple.

My least favorite is the third one.  While it's a clean fix to the problem, it slams the door on any future 'info powerpc' sub-commands.  It also
requires a fix so that prefix commands without any sub-commands can be depreciated.  Of course, we could just get rid of the "info powerpc"
command without depreciating it for a while first....

Let me know what you think.

-=# Paul #=-