From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25075 invoked by alias); 10 Sep 2005 03:56:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25067 invoked by uid 22791); 10 Sep 2005 03:56:35 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 10 Sep 2005 03:56:35 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EDwTh-0006JC-8c; Fri, 09 Sep 2005 23:56:33 -0400 Date: Sat, 10 Sep 2005 03:56:00 -0000 From: Daniel Jacobowitz To: Chao-ying Fu Cc: gdb-patches@sourceware.org, echristo@apple.com Subject: Re: [patch ping2] Simulator Supports for MIPS32 DSP ASE Message-ID: <20050910035633.GA24152@nevyn.them.org> Mail-Followup-To: Chao-ying Fu , gdb-patches@sourceware.org, echristo@apple.com References: <001501c5b401$143d8430$a914a8c0@MIPS.COM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001501c5b401$143d8430$a914a8c0@MIPS.COM> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00064.txt.bz2 On Wed, Sep 07, 2005 at 04:08:36PM -0700, Chao-ying Fu wrote: > Hello, > > I posted this patch on Aug 12. Could anyone review it? > http://sources.redhat.com/ml/gdb-patches/2005-08/msg00147.html > > Thanks a lot! I just can't review this patch; I don't know enough about the simulator framework or igen. Is there anyone out there who feels capable? If so, could you take a look, please? The only comment I have is that a number of files say: # Copyright (C) 2005 MIPS Technologies, Inc. # All rights reserved. I presume you intended to assign this to the FSF. If so, please fix that notice. -- Daniel Jacobowitz CodeSourcery, LLC