From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4023 invoked by alias); 7 Sep 2005 00:29:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3979 invoked by uid 22791); 7 Sep 2005 00:29:24 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 07 Sep 2005 00:29:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j870RjFN007614 for ; Tue, 6 Sep 2005 20:27:45 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j870RjV25324 for ; Tue, 6 Sep 2005 20:27:45 -0400 Received: from localhost.localdomain (vpn50-99.rdu.redhat.com [172.16.50.99]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id j870RidC009701 for ; Tue, 6 Sep 2005 20:27:44 -0400 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id j870RdG8027170 for ; Tue, 6 Sep 2005 17:27:39 -0700 Date: Wed, 07 Sep 2005 00:29:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [commit] mn10300-linux: Add shared library support Message-ID: <20050906172738.5d00e761@ironwood.lan> In-Reply-To: <20050907000613.GA18692@nevyn.them.org> References: <20050906161757.7576b069@ironwood.lan> <20050907000613.GA18692@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-09/txt/msg00041.txt.bz2 On Tue, 6 Sep 2005 20:06:13 -0400 Daniel Jacobowitz wrote: > May I recommend svr4_ilp32_fetch_link_map_offsets instead? Yes, thanks! I've just committed the following change: * mn10300-linux-tdep.c (mn10300_linux_svr4_fetch_link_map_offsets): Delete. (am33_linux_init_osabi): Register svr4_ilp32_fetch_link_map_offsets instead. Index: mn10300-linux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mn10300-linux-tdep.c,v retrieving revision 1.2 diff -u -p -r1.2 mn10300-linux-tdep.c --- mn10300-linux-tdep.c 6 Sep 2005 23:14:44 -0000 1.2 +++ mn10300-linux-tdep.c 7 Sep 2005 00:22:03 -0000 @@ -468,49 +468,6 @@ am33_regset_from_core_section (struct gd am33_collect_gregset_method); } -/* Fetch, and possibly build, an appropriate link_map_offsets structure - for mn10300 linux targets using the struct offsets defined in . - Note, however, that link.h is not actually referred to in this file. - Instead, the relevant structs offsets were obtained from examining - link.h. (We can't refer to link.h from this file because the host - system won't necessarily have it, or if it does, the structs which - it defines will refer to the host system, not the target.) */ - -struct link_map_offsets * -mn10300_linux_svr4_fetch_link_map_offsets (void) -{ - static struct link_map_offsets lmo; - static struct link_map_offsets *lmp = 0; - - if (lmp == 0) - { - lmp = &lmo; - - lmo.r_debug_size = 8; /* Actual size is 20, but this is all we - need. */ - - lmo.r_map_offset = 4; - lmo.r_map_size = 4; - - lmo.link_map_size = 20; /* Might be larger, but this is all we - need. */ - - lmo.l_addr_offset = 0; - lmo.l_addr_size = 4; - - lmo.l_name_offset = 4; - lmo.l_name_size = 4; - - lmo.l_next_offset = 12; - lmo.l_next_size = 4; - - lmo.l_prev_offset = 16; - lmo.l_prev_size = 4; - } - - return lmp; -} - /* AM33 Linux osabi has been recognized. Now's our chance to register our corefile handling. */ @@ -520,7 +477,7 @@ am33_linux_init_osabi (struct gdbarch_in set_gdbarch_regset_from_core_section (gdbarch, am33_regset_from_core_section); set_solib_svr4_fetch_link_map_offsets - (gdbarch, mn10300_linux_svr4_fetch_link_map_offsets); + (gdbarch, svr4_ilp32_fetch_link_map_offsets); } void