From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17971 invoked by alias); 5 Sep 2005 17:32:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17955 invoked by uid 22791); 5 Sep 2005 17:32:23 -0000 Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 05 Sep 2005 17:32:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.12.10/8.12.10) with ESMTP id j85HWLO0154174 for ; Mon, 5 Sep 2005 17:32:21 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j85HWLIc159006 for ; Mon, 5 Sep 2005 19:32:21 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11/8.13.3) with ESMTP id j85HWLhU016795 for ; Mon, 5 Sep 2005 19:32:21 +0200 Received: from 53v30g15.boeblingen.de.ibm.com (53v30g15.boeblingen.de.ibm.com [9.152.26.155]) by d12av02.megacenter.de.ibm.com (8.12.11/8.12.11) with ESMTP id j85HWLkK016792; Mon, 5 Sep 2005 19:32:21 +0200 Received: from 53v30g15.boeblingen.de.ibm.com (localhost [127.0.0.1]) by 53v30g15.boeblingen.de.ibm.com (8.12.10/8.12.10) with ESMTP id j85HW0om030682; Mon, 5 Sep 2005 19:32:00 +0200 Received: (from uweigand@localhost) by 53v30g15.boeblingen.de.ibm.com (8.12.10/8.12.10/Submit) id j85HVxKc030681; Mon, 5 Sep 2005 19:31:59 +0200 From: Ulrich Weigand Message-Id: <200509051731.j85HVxKc030681@53v30g15.boeblingen.de.ibm.com> Subject: Re: [RFC/RFA] Target vectors for native Linux targets To: drow@false.org (Daniel Jacobowitz) Date: Mon, 05 Sep 2005 17:32:00 -0000 Cc: uweigand@de.ibm.com (Ulrich Weigand), mark.kettenis@xs4all.nl (Mark Kettenis), manjo@austin.ibm.com, gdb-patches@sources.redhat.com In-Reply-To: <20050904224653.GC1978@nevyn.them.org> from "Daniel Jacobowitz" at Sep 04, 2005 06:46:53 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2005-09/txt/msg00026.txt.bz2 Daniel Jacobowitz wrote: >I'm presenting an alternative patch, stealing bits from mine last >December and other clever bits from Ulrich's. His patch was much >prettier than mine - but missed some important things that generated >ugliness in my first patch (for instance non-FETCH_INFERIOR_REGISTERS >targets). I've come up with cleaner solutions than I did the first >time round. Thanks for looking into this again! > On Fri, Aug 19, 2005 at 02:51:24AM +0200, Ulrich Weigand wrote: > > One problem with the conversion is that I wouldn't want to have to > > convert all the various Linux subtargets at the same time. It's a > > lot of work, and I'm unable to test most of those platforms. Thus > > I've thought of a way to stage the conversion: > > I bit the bullet and did them all, since I had most of it lying around > anyway. Excellent ;-) > This patch has only been tested on i686-pc-linux-gnu at the moment, but > it's been mightily proofread, and I have high confidence in it. It > obsoletes about half your posted patch for S/390 (the watchpoint bits > are an obvious follow-up). Could you give this a spin on S/390 for me? Your patch works fine with no regressions on s390-ibm-linux and s390x-ibm-linux. I'll be happy to do the watchpoint bits once your patch is committed ... > + /* FIXME drow/2005-09-04: The hardcoded use of register_addr should go > + away. This requires disentangling the various definitions of it > + (particularly alpha-nat.c's). */ > +#ifdef FETCH_INFERIOR_REGISTERS > + t = inf_ptrace_target (); > +#else > + t = inf_ptrace_trad_target (register_addr); > +#endif This means FETCH_INFERIOR_REGISTERS needs to be kept around in various nm-linux.h files for now? I'd have hoped to get rid of at least the s390 variant ... Bye, Ulrich -- Dr. Ulrich Weigand Linux on zSeries Development Ulrich.Weigand@de.ibm.com