Re: fix "too much information" bug w/ "info vector" on PowerPC

Jim Blandy
2005-08-30T21:44:05Z

Paul Gilliam <pgilliam@us.ibm.com> writes:
> I was temped to commit this is obvious, but wanted the warm fuzzy of
> peer review.

Well, you can have the cold slimy of a review from me. :)

Yes, that looks right. Comments:

- Could you also add comments above the definitions of
tdep->ppc_vr0_regnum and tdep->ppc_ev0_regnum in ppc-tdep.h?
Perhaps such comments could have prevented the bugs's appearance in
the first place.

- I'm not sure why the indentation in your patch is weird, but in any
case, there seems to be a preference for using spaces in new code,
not tabs.

Thanks!