From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26846 invoked by alias); 2 Sep 2005 00:55:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26361 invoked by uid 22791); 2 Sep 2005 00:55:32 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 02 Sep 2005 00:55:32 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EAzq1-0007tK-HK; Thu, 01 Sep 2005 20:55:25 -0400 Date: Fri, 02 Sep 2005 00:55:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC Message-ID: <20050902005525.GA30315@nevyn.them.org> Mail-Followup-To: Jim Blandy , pgilliam@us.ibm.com, gdb-patches@sources.redhat.com References: <200508301459.57189.pgilliam@us.ibm.com> <200508311323.15337.pgilliam@us.ibm.com> <20050831203248.GA18491@nevyn.them.org> <200508311729.12499.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-09/txt/msg00008.txt.bz2 On Thu, Sep 01, 2005 at 04:06:08PM -0700, Jim Blandy wrote: > Paul Gilliam writes: > > > Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h are over 80 columns and > > real ugly. > > > > Here, for your consideration, are two patches to change that: one uses a short-lived macro (ppc-tdep.patch) and the other uses a > > typedef (newest.patch). > > If I were to use a typedef, I'd put it in gdbarch.h and call it > gdb_retval_convention_t; there's nothing special about ppc-tdep.h's > needs. > > The following is also legal C, Emacs-friendly, and gdb_indent.sh-friendly: > > enum return_value_convention (ppc_sysv_abi_return_value > (struct gdbarch *gdbarch, > struct type *valtype, > struct regcache *regcache, > gdb_byte *readbuf, > const gdb_byte *writebuf)); > > I used this once before, but Mark Kettenis declared it "weird" or > something and asked me to take it out. :) Be that as it may, I think > it's better than the macro or the local typedef. It is weird :-P What's so wrong with enum return_value_convention ppc_sysv_abi_return_value (struct gdbarch *, struct type *, struct regcache *, gdb_byte *, const gdb_byte *); -- Daniel Jacobowitz CodeSourcery, LLC