From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7379 invoked by alias); 30 Aug 2005 22:30:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7324 invoked by uid 22791); 30 Aug 2005 22:29:59 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 30 Aug 2005 22:29:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EAEc7-0004V7-Cb; Tue, 30 Aug 2005 18:29:55 -0400 Date: Tue, 30 Aug 2005 22:44:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: fix "too much information" bug w/ "info vector" on PowerPC Message-ID: <20050830222955.GA17207@nevyn.them.org> Mail-Followup-To: Jim Blandy , pgilliam@us.ibm.com, gdb-patches@sources.redhat.com References: <200508301459.57189.pgilliam@us.ibm.com> <20050830214629.GA16018@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00258.txt.bz2 On Tue, Aug 30, 2005 at 03:22:51PM -0700, Jim Blandy wrote: > > Daniel Jacobowitz writes: > > On Tue, Aug 30, 2005 at 02:42:31PM -0700, Jim Blandy wrote: > >> - I'm not sure why the indentation in your patch is weird, but in any > >> case, there seems to be a preference for using spaces in new code, > >> not tabs. > > > > Er, really? GNU convention is tabs, as far as I know. > > I don't see anything in the coding standards, but maybe I've missed > something. > > Avoiding tab characters makes patches read normally and avoids > problems with different tab sizes. And all the popular editors can be > configured to make the 'tab' command use either. Most of the other > Free software projects I know of have a convention of using spaces. I know all these things - but they aren't relevant to GDB. GDB has about eight times more code using tabs than spaces (I just checked). Let's not dribble in the opposite direction without a deliberate decision, please. IIRC GCC and binutils also use a tab convention. -- Daniel Jacobowitz CodeSourcery, LLC