Re: MI testsuite mi-until.exp failures

[Daniel Jacobowitz <drow@false.org>]

On Tue, Aug 16, 2005 at 11:17:18PM -0400, Bob Rossi wrote:
> Hi,
> 
> Using gcc 4.0, I get error's with the mi-until.exp and mi2-until.exp
> testcases. The first issue is trivial.
> 
> The file mi-var-child.c needed '#include <string.h>' in order for the
> file to compile because of memset. Is string.h appropriate for this? I
> know memset can be in different headers on different systems.

<string.h> is fine.  I do these things mostly by example: for instance
call-ar-st.c already includes it unconditionally so it must be OK for
the testsuite, on targets anyone's cared about lately.

This bit is OK, feel free to commit it on its own.

> Also, for some reason, the line number was different. So, either it's OK
> for the line number to be different and this patch is OK, or it's not OK
> for the line number to be different and this patch is bad. Any ideas?

Well that doesn't tell me much, and I hate decoding regexps to figure
this stuff out.  What's the command?  Where's it stopping?  Where's it
supposed to stop?  Does the behavior seem reasonable to you?

I seem to recall that this sparked some contention about the correct
behavior of "until", which we discussed on gdb@ some months ago.  That
may have been a different bug, though.

-- 
Daniel Jacobowitz
CodeSourcery, LLC